Skip to content

Move BashOperator template field logic from __init__ to execute#70429

Open
Kunal8954 wants to merge 3 commits into
apache:mainfrom
Kunal8954:fix-bashoperator-template-field-init
Open

Move BashOperator template field logic from __init__ to execute#70429
Kunal8954 wants to merge 3 commits into
apache:mainfrom
Kunal8954:fix-bashoperator-template-field-init

Conversation

@Kunal8954

Copy link
Copy Markdown

Related to #70296

Summary

Moves the template-field-dependent logic in BashOperator.__init__ (determining whether bash_command is an inline command or a script file) into execute(), since template fields are only rendered after __init__ runs. Previously this check ran on the un-rendered Jinja expression.

Changes

  • Removed self._is_inline_cmd computation from __init__
  • Added equivalent is_inline_cmd computation inside execute(), using the already-rendered self.bash_command
  • Removed BashOperator entry from validate_operators_init_exemptions.txt

@boring-cyborg

boring-cyborg Bot commented Jul 25, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Kunal8954

Copy link
Copy Markdown
Author

I've opened a PR for BashOperator: #70429
Moved the _is_inline_cmd check out of init and into execute(), since it was operating on the un-rendered bash_command template field. Also removed the BashOperator entry from validate_operators_init_exemptions.txt.
This is my first contribution to Airflow, happy to make any changes if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant