Move Compute Engine validation out of constructors - #70454
Merged
shahar1 merged 2 commits intoJul 26, 2026
Conversation
daesung9511
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
shahar1
as code owners
July 26, 2026 01:29
shahar1
reviewed
Jul 26, 2026
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Well done! Minor comments to handle and we're good to go
Kunal8954
pushed a commit
to Kunal8954/airflow
that referenced
this pull request
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Compute Engine input validation and template-dependent transformations out of operator constructors.
The affected operators previously performed validation and derived values such as resource_id during init. Because template fields are rendered after operator initialization, this caused validation and transformation logic to run against unrendered values.
@shahar1
This change:
Tests:
related: #70296
Was generative AI tooling used to co-author this PR?