Skip to content

Fix async Beam subprocess launch#70456

Open
avzamelek wants to merge 1 commit into
apache:mainfrom
avzamelek:fix/beam-async-subprocess-shell
Open

Fix async Beam subprocess launch#70456
avzamelek wants to merge 1 commit into
apache:mainfrom
avzamelek:fix/beam-async-subprocess-shell

Conversation

@avzamelek

@avzamelek avzamelek commented Jul 26, 2026

Copy link
Copy Markdown

What

Remove the redundant shell=True argument from
BeamAsyncHook.run_beam_command_async.

asyncio.create_subprocess_shell() already starts the subprocess through a
shell. Passing shell=True again is forwarded to subprocess.Popen, where it
conflicts with the value supplied internally and raises a TypeError.

Test coverage

Add a focused async unit test that verifies the subprocess launcher is called
without the duplicate shell keyword.

Testing

  • git diff --check

  • Attempted the focused regression test with Breeze:

    breeze run pytest providers/apache/beam/tests/unit/apache/beam/hooks/test_beam.py::TestBeamAsyncHook::test_run_beam_command_async_does_not_pass_shell_keyword -q
  • Breeze test setup was completed successfully.

  • The targeted test was run locally using Docker and passed successfully.

Scope

This is a bug fix for the Apache Beam provider's async execution path. It does
not change command construction or shell-escaping behavior.

Development assistance

Claude Code Fable 5 was used as a development assistant during investigation and
implementation. The final diff was reviewed by human before submission.

@boring-cyborg

boring-cyborg Bot commented Jul 26, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants