Fix async Beam subprocess launch#70456
Open
avzamelek wants to merge 1 commit into
Open
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the redundant
shell=Trueargument fromBeamAsyncHook.run_beam_command_async.asyncio.create_subprocess_shell()already starts the subprocess through ashell. Passing
shell=Trueagain is forwarded tosubprocess.Popen, where itconflicts with the value supplied internally and raises a
TypeError.Test coverage
Add a focused async unit test that verifies the subprocess launcher is called
without the duplicate
shellkeyword.Testing
git diff --checkAttempted the focused regression test with Breeze:
Breeze test setup was completed successfully.
The targeted test was run locally using Docker and passed successfully.
Scope
This is a bug fix for the Apache Beam provider's async execution path. It does
not change command construction or shell-escaping behavior.
Development assistance
Claude Code Fable 5 was used as a development assistant during investigation and
implementation. The final diff was reviewed by human before submission.