Skip to content

Validate TriggerDagRunOperator logical_date after template rendering - #70490

Merged
henry3260 merged 2 commits into
apache:mainfrom
mitre88:fix-trigger-dagrun-template
Jul 27, 2026
Merged

Validate TriggerDagRunOperator logical_date after template rendering#70490
henry3260 merged 2 commits into
apache:mainfrom
mitre88:fix-trigger-dagrun-template

Conversation

@mitre88

@mitre88 mitre88 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

logical_date is a template field of TriggerDagRunOperator, but its str/datetime/None type validation ran in __init__, before Jinja rendering. The check now runs at the top of execute() on the rendered value (run_after keeps its constructor validation — it is not a template field). Removes the class from the exemption list.

related: #70296


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Fable 5)

Generated-by: Claude Code (Fable 5) following the guidelines

logical_date is a template field, but its type validation ran in __init__,
before Jinja rendering. Validate in execute() instead so the rendered value
is what gets checked.
@henry3260

Copy link
Copy Markdown
Contributor

re-run the CI test

@henry3260
henry3260 merged commit 6bef2b4 into apache:main Jul 27, 2026
155 checks passed
@boring-cyborg

boring-cyborg Bot commented Jul 27, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-3-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 6bef2b4 v3-3-test

This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants