Rename Neptune operator db_cluster_id argument to cluster_id - #70491
Open
mitre88 wants to merge 1 commit into
Open
Rename Neptune operator db_cluster_id argument to cluster_id#70491mitre88 wants to merge 1 commit into
mitre88 wants to merge 1 commit into
Conversation
mitre88
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
o-nikolas and
potiuk
as code owners
July 27, 2026 00:34
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
Member
|
Since this is breaking either way, maybe it’s easier to rename the argument instead? |
The operators template their cluster_id attribute while the constructor exposes it as db_cluster_id, so the exemption-list validator flags the mismatch. Renaming the argument keeps the templated attribute and its template_fields entry stable and makes a wrong keyword fail loudly at construction time.
mitre88
force-pushed
the
fix-neptune-template-fields
branch
from
July 27, 2026 05:46
16f3351 to
3325b40
Compare
mitre88
changed the title
Contributor
Author
|
Good point — reworked the PR to rename the argument instead: the constructor now takes Drafted-by: Claude Code (Fable 5) (no human review before posting) |
vincbeck
approved these changes
Jul 27, 2026
vincbeck
left a comment
vincbeck
left a comment
Contributor
There was a problem hiding this comment.
This can be treated as a bug fix, I dont think we need a major version bump for this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the template-field validation burn-down tracked in #70296.
NeptuneStartDbClusterOperatorandNeptuneStopDbClusterOperatordeclarecluster_idintemplate_fieldsbut expose the value as thedb_cluster_idconstructor argument, assigningself.cluster_id = db_cluster_idin__init__— which thevalidate-operators-initcheck flags. Per review feedback, this renames the argument tocluster_id(rather than renaming the attribute as in the first iteration of this PR), so the templated attribute andtemplate_fieldsentry stay exactly as they are on main and existing Dags templating the attribute are unaffected.Breaking change: Dags passing
db_cluster_id=to these two operators must switch tocluster_id=, and now fail loudly with aTypeErrorat construction time. A note was added to the provider changelog. Thedb_cluster_idkeys in the operators' XCom return values and in the Neptune trigger/hook APIs are unchanged.Both classes are removed from the exemption list and the
validate-operators-initcheck passes locally, as do the unit tests.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines