Add aws_conn_id to template_fields in Amazon S3 operators (#35259) - #70638
Open
divijaksolves wants to merge 5 commits into
Open
Add aws_conn_id to template_fields in Amazon S3 operators (#35259)#70638divijaksolves wants to merge 5 commits into
divijaksolves wants to merge 5 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
Since this changes template_fields, should test_template_fields be updated to include a templated aws_conn_id?
…ateObjectOperator
Author
|
Thanks for the review! Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #35259
Description
This PR adds
aws_conn_idtotemplate_fieldsinS3CreateObjectOperatorto enable Jinja templating support for dynamic connection IDs.Testing
Tested locally via Breeze with:
pytest providers/amazon/tests/unit/amazon/aws/operators/test_s3.pyAll 79 tests passed successfully.
Was generative AI tooling used to co-author this PR?