Skip to content

Add aws_conn_id to template_fields in Amazon S3 operators (#35259) - #70638

Open
divijaksolves wants to merge 5 commits into
apache:mainfrom
divijaksolves:add-templated-aws-conn-id
Open

Add aws_conn_id to template_fields in Amazon S3 operators (#35259)#70638
divijaksolves wants to merge 5 commits into
apache:mainfrom
divijaksolves:add-templated-aws-conn-id

Conversation

@divijaksolves

Copy link
Copy Markdown

closes: #35259

Description

This PR adds aws_conn_id to template_fields in S3CreateObjectOperator to enable Jinja templating support for dynamic connection IDs.

Testing

Tested locally via Breeze with:
pytest providers/amazon/tests/unit/amazon/aws/operators/test_s3.py
All 79 tests passed successfully.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@divijaksolves
divijaksolves requested a review from o-nikolas as a code owner July 28, 2026 19:15
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Jul 28, 2026
@boring-cyborg

boring-cyborg Bot commented Jul 28, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@SameerMesiah97 SameerMesiah97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this changes template_fields, should test_template_fields be updated to include a templated aws_conn_id?

@divijaksolves

Copy link
Copy Markdown
Author

Thanks for the review! Updated test_template_fields in test_s3.py to include a templated aws_conn_id="aws_{{ ds }}" and verified that all 79 tests pass locally via Breeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow jinja templating connection ids for all third party operators

2 participants