Skip to content

Fix registry publish silently skipping for some docs publishers #70645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaxil wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

Fix registry publish silently skipping for some docs publishers #70645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/registry-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,15 @@ on: # yamllint disable-line rule:truthy
required: false
type: boolean
default: false
# `github.event_name` inside a called workflow reports the *caller's* event, never
# `workflow_call`, so it cannot distinguish the two entry points. An input declared
# only here can: it defaults to true when called and is undefined (falsy) on a
# `workflow_dispatch`. Callers must not pass it.
is-workflow-call:
description: "Internal: always true on the workflow_call path, do not pass explicitly"
required: false
type: boolean
default: true
secrets:
DOCS_AWS_ACCESS_KEY_ID:
required: true
Expand All @@ -81,7 +90,7 @@ jobs:
# such image and still builds its own.
if: >
(inputs.ci-image-already-built != true) && (
github.event_name == 'workflow_call' ||
inputs.is-workflow-call ||
contains(fromJSON('[
"ashb",
"bugraoz93",
Expand Down Expand Up @@ -117,11 +126,12 @@ jobs:
name: "Build & Publish Registry"
needs: [build-ci-image]
# `build-ci-image` is skipped when the caller stashed the image, so this cannot simply
# inherit its result — but it must keep enforcing the same committer allowlist that
# skipping that job used to enforce for us on a dispatch.
# inherit its result. On a dispatch it enforces the committer allowlist below; on the
# `workflow_call` path the caller has already gated on its own allowlist, so this must
# not re-check it against a second, separately-maintained copy.
if: >
!cancelled() && needs.build-ci-image.result != 'failure' && (
github.event_name == 'workflow_call' ||
inputs.is-workflow-call ||
contains(fromJSON('[
"ashb",
"bugraoz93",
Expand Down
Loading