[chart/v1-2x-test] Allow configuring key names in database credential secrets (#69954) - #70646
Merged
Merged
Conversation
… secrets (#69954) * Allow configuring key names in database credential secrets The chart hardcoded 'key: connection' in the secretKeyRef for the metadata, result backend, and broker URL env vars, so externally managed secrets using a different key (e.g. CloudNativePG's 'uri') could not be used with metadataSecretName and friends. Add data.metadataSecretKey, data.resultBackendSecretKey and data.brokerUrlSecretKey, defaulting to 'connection'. The custom key only applies when the corresponding *SecretName is provided, since chart-created secrets always write the 'connection' key. * Address review comments: clarify values and docs wording (cherry picked from commit dc75103) Co-authored-by: Preetham Sanji <141400461+PreethamSanji@users.noreply.github.com>
1 task
Miretpl
marked this pull request as ready for review
July 28, 2026 21:22
Miretpl
requested review from
Miretpl,
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
July 28, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart hardcoded 'key: connection' in the secretKeyRef for the metadata, result backend, and broker URL env vars, so externally managed secrets using a different key (e.g. CloudNativePG's 'uri') could not be used with metadataSecretName and friends.
Add data.metadataSecretKey, data.resultBackendSecretKey and data.brokerUrlSecretKey, defaulting to 'connection'. The custom key only applies when the corresponding *SecretName is provided, since chart-created secrets always write the 'connection' key.
(cherry picked from commit dc75103)
Co-authored-by: Preetham Sanji 141400461+PreethamSanji@users.noreply.github.com