Add tests for Keycloak token models - #70689
Open
dhkim1920 wants to merge 2 commits into
Open
Conversation
The token request models are exempted from provider test-structure enforcement, leaving grant discrimination and validation behavior without dedicated coverage.
vincbeck
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add focused unit coverage for the Keycloak token request and response models.
The tests cover password and client-credentials grant discrimination, validation failures, serialization, and delegation to the token service functions. The corresponding temporary exemption is removed from
OVERLOOKED_TESTS.Testing:
uv run --project providers/keycloak pytest providers/keycloak/tests/unit/keycloak/auth_manager/datamodels/test_token.py --cov=providers/keycloak/src/airflow/providers/keycloak/auth_manager/datamodels --cov-report=term-missing -xvsuv run --project providers/keycloak pytest providers/keycloak/tests/unit/keycloak -xvsuv run --project airflow-core pytest airflow-core/tests/unit/always/test_project_structure.py::TestProjectStructure::test_providers_modules_should_have_tests -xvsprek run --from-ref upstream/main --stage pre-commitprek run --from-ref upstream/main --stage manualbreeze --answer yes testing providers-tests --parallel-test-types "Providers[common.compat,keycloak]" --run-in-parallelWas generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines