Skip to content

Remove duplicate code in cli_config.py - #70785

Merged
potiuk merged 2 commits into
apache:mainfrom
rjgoyln:Remove_duplicate_code
Jul 30, 2026
Merged

Remove duplicate code in cli_config.py#70785
potiuk merged 2 commits into
apache:mainfrom
rjgoyln:Remove_duplicate_code

Conversation

@rjgoyln

@rjgoyln rjgoyln commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This PR primarily removes the duplicated code from src/airflowctl/ctl/cli_config.py.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve conflicts?

@rjgoyln
rjgoyln force-pushed the Remove_duplicate_code branch from 471a30d to 04a6c1d Compare July 30, 2026 18:31
@rjgoyln

rjgoyln commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Could you resolve conflicts?

Yes. I did it! Thanks.

@henry3260

Copy link
Copy Markdown
Contributor

CI error might be fixed by #70776

@potiuk
potiuk merged commit e9dadbc into apache:main Jul 30, 2026
67 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: airflow-ctl/v0-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
airflow-ctl/v0-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker e9dadbc airflow-ctl/v0-1-test

This should apply the commit to the airflow-ctl/v0-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants