Skip to content

Fix wtforms-mocking condition #70811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 31, 2026
Merged

Fix wtforms-mocking condition #70811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/api_fastapi/core_api/services/ui/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,14 @@ def mock_any_of(allowed_values: list) -> HookMetaService.MockEnum:
]:
try:
if not find_spec(mod_name):
raise ModuleNotFoundError
raise ModuleNotFoundError(f"No module named {mod_name!r}", name=mod_name)
except ModuleNotFoundError:
sys.modules[mod_name] = MagicMock()

# We conditionally inject mock classes for missing dependencies
# to ensure `ProvidersManager` can initialize hook connection widgets
# without crashing when FAB/WTForms are not installed.
if "wtforms.StringField" not in sys.modules:
if isinstance(sys.modules.get("wtforms"), MagicMock):
# Only apply mocks if the actual module wasn't loaded beforehand.
# This avoids thread-safety issues caused by `unittest.mock.patch` mutating global states.
with (
Expand Down