Reject Authentik OAuth id_tokens issued for another client - #70825
Closed
rjgoyln wants to merge 1 commit into
Closed
Reject Authentik OAuth id_tokens issued for another client#70825rjgoyln wants to merge 1 commit into
rjgoyln wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_jwtdecodes the Authentik id_token with authlib and callsclaims.validate()without passing
claims_options. authlib'svalidate_audreturns early when noaudoptionis supplied, so the audience is never compared against our own
client_id, even though OIDCrequires an ID Token's
audto contain the client id it was issued to. This pins the audienceat the decode site, and the issuer where it is configured.
Changes
_validate_jwttakes an optionalclaims_optionsand forwards it toauthlib_jwt.decode().It defaults to
None, so existing callers and subclass overrides behave as before._get_authentik_claims_options()pinsaudto the registeredclient_id.client_idisalways available, and per OIDC an id_token must carry it, so this holds for any compliant IdP.
issis only checked whenissueris present inserver_metadata, otherwise a warning islogged. Deployments that configure
jwks_urialone are a valid existing setup and keep working.Happy to make it mandatory instead if reviewers prefer that trade-off.
audience, audience list without our client, unexpected issuer, missing claims, and the
unconfigured-issuer fallback.
Was generative AI tooling used to co-author this PR?
generated-by: Claude Code (Opus 5)
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.