Fix BteqOperator declaring template_fields as a bare string - #70862
Merged
Conversation
A bare string is a sequence of characters, so "sql" declares the fields "s", "q" and "l" rather than "sql". Airflow papers over this by wrapping the string in a list, but it emits a UserWarning every time a task is built, and any code reading the class attribute directly still sees the wrong value.
potiuk
approved these changes
Aug 1, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
Good catch. template_fields = "sql" declared three fields — "s", "q" and "l" — since a string is a sequence of characters.
The base operator wraps it at runtime so rendering still worked, but it warned on every task instantiation with "Please update {task_type} accordingly", and anything reading the class attribute before instantiation (the sphinx template-fields doc role, dry_run(), _set_xcomargs_dependencies()) saw the wrong value.
Nice that you also fixed the test — it was asserting == "sql", so it was pinning the bug in place.
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BteqOperatordeclaredtemplate_fields = "sql". A bare string is a sequence ofcharacters, so this declares the fields
"s","q"and"l"rather than"sql".Airflow papers over this in
BaseOperator.__init__, which wraps a stringtemplate_fieldsin a list, but it emits aUserWarningevery time a task isbuilt, and any code reading the class attribute directly — the sphinx
template-fieldsdoc role,dry_run(),_set_xcomargs_dependencies()— stillsees the wrong value.
Declaring it as
Sequence[str] = ("sql",)matches every other operator in thecodebase and drops the warning.
The existing
test_template_fieldsasserted the incorrect value, so it is updatedto the corrected one (and a stray
printremoved).Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.