[v3-3-test] Fix mypy failure on datadog timer wrapped by shared observability Timer (#69202) - #70887
Merged
Merged
Conversation
…er (apache#69202) The real_timer parameter accepts any backend timer exposing start/stop (pystatsd, dogstatsd), not the shared Timer itself. Typing it against a minimal protocol reflects that contract and stops mypy rejecting the typed dogstatsd TimedContextManagerDecorator. (cherry picked from commit 5946046)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #69202 to
v3-3-test.mypy-shared-observabilityfails on every PR targetingv3-3-test:datadog_logger.pypasses dogstatsd'sTimedContextManagerDecoratorintoTimer(...), whosereal_timeris typedTimer | None. The fix retypes itagainst a minimal
BackendTimerProtocol(start()/stop()), which is whatthe parameter actually accepts. Type-annotation-only, no runtime change.
This unblocks static checks on the branch — e.g. #70855, #70854, #70852.
(cherry picked from commit 5946046)
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines