Give each task its own start trigger arguments in standard sensors - #70888
Merged
potiuk merged 1 commit intoAug 1, 2026
Merged
Conversation
start_trigger_args is a class attribute, so assigning through it in __init__ overwrote the arguments shared by every other task built from the same operator. Two DateTimeSensorAsync tasks in one Dag both waited for whichever moment was constructed last, and the same applied to TimeSensor's moment and FileSensor's path and timeout.
shahar1
approved these changes
Aug 1, 2026
jroachgolf84
approved these changes
Aug 1, 2026
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 16b4e62 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_trigger_argsis a class attribute onDateTimeSensorAsync,TimeSensorandFileSensor, and each one assigned through it in__init__:That mutates the shared class-level object instead of creating an instance attribute, so
every task built from the operator ends up advertising the arguments of whichever task was
constructed last.
Reproducer on
main:With
start_from_trigger=Truethe task starts directly in the triggerer from thesearguments, so two
DateTimeSensorAsynctasks in one Dag both wait for the same moment. Thesame applies to
TimeSensor's moment and toFileSensor'sfilepath,recursive,poke_intervalandtimeout.Each sensor now replaces
start_trigger_argswith a fresh copy viadataclasses.replace,which binds an instance attribute and leaves the class-level template untouched for the next
task built from it.
Regression tests are added for all three sensors; each fails on
main.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines