Support Monaco Editor 0.56 public exports - #70937
Open
szzhoujiarui wants to merge 3 commits into
Open
Conversation
Monaco 0.56 enforces its package exports, so private deep imports prevent the UI from linting and building after the dependency upgrade.
szzhoujiarui
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 2, 2026 05:11
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Monaco Editor to 0.56 and replace private
esm/vsimports with the package's public exports.Register folding, find, codicon, and JSON features through public entry points. Retain Airflow's explicit registration of its patched Python grammar so f-string tokenization remains intact.
This keeps Monaco workers and language features compatible with 0.56 and avoids private module paths that no longer resolve in Vite.
closes: #70929
Testing
CI=true corepack pnpm@10.25.0 install --frozen-lockfilecorepack pnpm@10.25.0 test— 102 files and 777 tests passedcorepack pnpm@10.25.0 exec vitest run src/components/MonacoEditor/pythonFStrings.test.ts— 12 tests passedcorepack pnpm@10.25.0 lintcorepack pnpm@10.25.0 buildbreeze ci selective-check --commit-ref 421c0c9breeze testing ui-e2e-tests --test-pattern "dag-code-tab.spec.ts" --workers 1— blocked during environment checks because Docker is unavailable in the current environmentWas generative AI tooling used to co-author this PR?
Generated-by: MonkeyCode (GPT-5.6 Sol) following the guidelines
Drafted-by: MonkeyCode (GPT-5.6 Sol); reviewed by @szzhoujiarui before posting