Skip to content

Stop dumping every Dag to stdout when syncing FAB permissions - #70939

Merged
henry3260 merged 1 commit into
apache:mainfrom
Eason09053360:remove-debug-print-from-fab-perm-sync
Aug 3, 2026
Merged

Stop dumping every Dag to stdout when syncing FAB permissions#70939
henry3260 merged 1 commit into
apache:mainfrom
Eason09053360:remove-debug-print-from-fab-perm-sync

Conversation

@Eason09053360

Copy link
Copy Markdown
Contributor

Left over from debugging; the sync_perm command already reports what it is doing, so this only adds one line of raw repr per Dag on top of it.

create_dag_specific_permissions printed every Dag's repr to stdout. It was added
in #53918, a refactor that had no reason to introduce output, and it is the only
bare print in the FAB provider outside cli_commands/ — every other one carries
a human-readable message.

The sync_perm command already prints "Updating permission on all DAG views"
before calling into this method, so the repr line is pure noise on top of it.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Left over from debugging; the sync_perm command already reports what it is
doing, so this only adds one line of raw repr per Dag on top of it.
@Eason09053360
Eason09053360 marked this pull request as ready for review August 2, 2026 09:37
@Eason09053360
Eason09053360 requested a review from vincbeck as a code owner August 2, 2026 09:37

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@henry3260
henry3260 merged commit 2db44cd into apache:main Aug 3, 2026
105 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants