Skip to content

Remove the dead CFullLoader branch from the YAML helpers #70943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjgoyln wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −12
Open

Remove the dead CFullLoader branch from the YAML helpers #70943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions airflow-core/src/airflow/utils/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ def __getattr__(name):
# Delegate anything else to the yaml module
import yaml

if name == "FullLoader":
# Try to use CFullLoader by default
getattr(yaml, "CFullLoader", yaml.FullLoader)

# FullLoader stays pyyaml's on purpose: CFullLoader does not see add_constructor
# registrations, so custom tags would raise ConstructorError instead of resolving.
return getattr(yaml, name)
6 changes: 2 additions & 4 deletions airflow-ctl/src/airflowctl/ctl/utils/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ def __getattr__(name):
# Delegate anything else to the yaml module
import yaml

if name == "FullLoader":
# Try to use CFullLoader by default
getattr(yaml, "CFullLoader", yaml.FullLoader)

# FullLoader stays pyyaml's on purpose: CFullLoader does not see add_constructor
# registrations, so custom tags would raise ConstructorError instead of resolving.
return getattr(yaml, name)
6 changes: 2 additions & 4 deletions task-sdk/src/airflow/sdk/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ def __getattr__(name):
# Delegate anything else to the yaml module
import yaml

if name == "FullLoader":
# Try to use CFullLoader by default
getattr(yaml, "CFullLoader", yaml.FullLoader)

# FullLoader stays pyyaml's on purpose: CFullLoader does not see add_constructor
# registrations, so custom tags would raise ConstructorError instead of resolving.
return getattr(yaml, name)