Fix airflowctl commands failing against older Airflow servers - #70954
Draft
Lee-W wants to merge 1 commit into
Draft
Fix airflowctl commands failing against older Airflow servers#70954Lee-W wants to merge 1 commit into
Lee-W wants to merge 1 commit into
Conversation
airflowctl's datamodels are generated from the newest Airflow API spec, so a server on an older Airflow line legitimately omits fields the models declare as required. Collection responses already tolerated that via fill_missing_fields, added in apache#63388 for exactly this reason, but only inside execute_list. Every single-object response validated strictly, so commands such as dags get-details, dags unpause and dags update failed: ValidationError: 2 validation errors for DAGResponse is_backfillable Field required timetable_periodic Field required against any Airflow older than the line the models were generated from. Lift the validation out of execute_list into a shared validate_response() and use it for all 46 single-object responses. LoginOperations keeps strict validation on purpose — a defaulted token should fail loudly rather than be filled in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflowctl's datamodels are generated from the newest Airflow API spec, so a server on an older Airflow line legitimately omits fields the models declare as required. Collection responses already tolerated that via fill_missing_fields, added in #63388 for exactly this reason, but only inside execute_list. Every single-object response validated strictly, so commands such as dags get-details, dags unpause and dags update failed:
against any Airflow older than the line the models were generated from.
Lift the validation out of execute_list into a shared validate_response() and use it for all 46 single-object responses. LoginOperations keeps strict validation on purpose — a defaulted token should fail loudly rather than be filled in.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.