Fix airflowctl list operations ignoring the requested offset - #70989
Merged
henry3260 merged 3 commits intoAug 4, 2026
Conversation
The paginating helper behind the list operations built its query params without the caller's offset, so the first request always started at the server default. The paging loop then resumed at offset + limit, meaning a non-zero offset both returned the wrong first page and silently skipped the rows in between. The parameter is public on the signature, so the mismatch was waiting for the first caller that used it.
rjgoyln
marked this pull request as ready for review
August 4, 2026 05:47
rjgoyln
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
August 4, 2026 05:47
henry3260
approved these changes
Aug 4, 2026
henry3260
left a comment
henry3260
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, just one nit
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Removed duplicate assertion for response.hellos.
henry3260
added
the
backport-to-airflow-ctl-v0-1-test
Contributor
Backport failed to create: airflow-ctl-v0-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker b541458 airflow-ctl-v0-1-testThis should apply the commit to the airflow-ctl-v0-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseOperations.execute_listaccepts anoffsetbut never sent it on the first request, so paging started at the server default while the loop still resumed atoffset + limit— a non-zero offset both returned the wrong first page and skipped the rows in between.offset=100, limit=2returned rows 0-1, then jumped to row 102.Nothing released is affected: no caller passes
offset, andjobs listtakes a separate path when one is given. But the parameter is public on the signature and silently discarded, so the first caller to use it gets wrong results rather than an error.Compatibility
Sending
offset=0is equivalent to omitting it — the API'sQueryOffsetalready defaults to0.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines