Support nested classes in import_string - #71016
Closed
KushagraB424 wants to merge 2 commits into
Closed
Conversation
This adds a fallback mechanism to iteratively resolve nested class boundaries when the standard module import fails, fully addressing an existing TODO. This ensures nested classes can be dynamically loaded without modifying existing top-level behavior.
KushagraB424
requested review from
amoghrajesh,
ashb,
kaxil and
potiuk
as code owners
August 3, 2026 20:03
Member
|
We can remove the TODO, I don't think we need to support that use-case unless we need it |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for importing nested classes using the
import_stringutility, resolving an existingTODO.Currently,
import_stringstrictly splits at the last dot and attempts to import the first part as a module. This immediately throws anImportErrorif the dotted path points to a nested class inside another class (e.g.,my_module.TopLevelClass.NestedClass).The updated logic introduces a safe fallback mechanism. If the original split throws an
ImportError, it iteratively searches backwards to find the longest valid base module path. Once the module is successfully imported, it recursively resolves the rest of the path usinggetattr().This introduces no breaking changes to the default behavior. Unit tests have been added to verify that nested classes load properly.
closes: #71014
Was generative AI tooling used to co-author this PR?
Generated-by: [Antigravity] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.