Render multi-branch review choices as a multi-select - #71046
Merged
Conversation
guan404ming
force-pushed
the
llm-branch-multiselect
branch
from
August 4, 2026 03:39
1f5d702 to
3623ecd
Compare
guan404ming
marked this pull request as ready for review
August 4, 2026 08:36
guan404ming
requested review from
Lee-W,
gopidesupavan and
kaxil
as code owners
August 4, 2026 08:36
kaxil
reviewed
Aug 4, 2026
kaxil
approved these changes
Aug 4, 2026
Member
Author
|
Thanks! |
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
related: #70651 (comment)
allow_multiple_branches=True, reviewers edit branch choices as free-text JSON; a typo fails only at resume, wasting the approval and an LLM call.How
{"type": "array", "enum": [...]}so the review form renders a multi-select.E2E
Verified against a live Airflow (breeze, pydantic-ai TestModel): the review form renders the multi-select pre-filled with the LLM's choice (
billing), the reviewer addsinfra, and after Approve the run finishes withbilling/infrasuccess andauthskipped.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines