Reject serde-reserved keys in HITL params_input - #71054
Open
haseebmalik18 wants to merge 5 commits into
Open
Conversation
haseebmalik18
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
August 4, 2026 05:00
haseebmalik18
changed the title
eladkal
added
type:bug-fix
Contributor
|
This doesn't have to be in 3.3.1, but if we are comfortable (cc @Lee-W) we can consider it. |
Lee-W
reviewed
Aug 4, 2026
Member
|
A few nitpicks, but overall this looks good. I also don't think it's worth blocking the 3.3.1 release. |
Contributor
|
Moved to 3.3.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A HITL response whose
params_inputcontains a serde-reserved key (__classname__or__id__) cannot be serialized when the task resumes. Today the response is silently discarded and the user has no way to resubmit a corrected one.This validates
params_inputwhen the response is submitted and returns a 400 if it carries one of those keys, before anything is written. The task stays inAWAITING_INPUT, so the user can fix the input and resubmit.Only the public HITL route needs this. The execution API route builds its
params_inputfrom trusted operator code rather than user input, so it is left as is.closes: #71036