Skip to content

deny unknown backfill_id directly instead of falling back to body dag_id - #71114

Open
bujjibabukatta wants to merge 3 commits into
apache:mainfrom
bujjibabukatta:fix/#71080
Open

deny unknown backfill_id directly instead of falling back to body dag_id#71114
bujjibabukatta wants to merge 3 commits into
apache:mainfrom
bujjibabukatta:fix/#71080

Conversation

@bujjibabukatta

Copy link
Copy Markdown
Contributor

Summary

Fixes an authorization bug in requires_access_backfill where an unknown backfill_id could be distinguished from a forbidden one by response status code, leaking which backfill ids exist.

Root Cause

When backfill_id was present but matched no row, dag_id stayed None — the same as when there was no backfill_id at all — so the check fell through to authorizing against a dag_id from the request body instead of denying outright.

Fix

If backfill_id is given but matches no row, deny immediately with 403 Forbidden (the same response a forbidden-but-existing backfill gets), instead of falling back to the body-supplied dag_id.

Closes: #71080

Was generative AI tooling used ?

  • Yes - Claude

Generated-by: Claude following the guidelines

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Aug 4, 2026
@bujjibabukatta bujjibabukatta changed the title fix: deny unknown backfill_id directly instead of falling back to bod… fix: deny unknown backfill_id directly instead of falling back to body dag_id Aug 4, 2026
@bujjibabukatta bujjibabukatta changed the title fix: deny unknown backfill_id directly instead of falling back to body dag_id deny unknown backfill_id directly instead of falling back to body dag_id Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backfill authorization falls back to the request body when the backfill does not exist

1 participant