Fix version_added for the concurrent pod creation options - #71157
Open
1fanwang wants to merge 2 commits into
Open
Fix version_added for the concurrent pod creation options#711571fanwang wants to merge 2 commits into
1fanwang wants to merge 2 commits into
Conversation
async_pod_creation and pod_creation_max_concurrency are tagged version_added: 10.20.0, but they ship in cncf-kubernetes 10.21.0. Neither name appears anywhere in the released 10.20.0 distribution. The docs build turns this into a ".. versionadded:: 10.20.0" directive on the configuration reference page, so a reader planning an upgrade is pointed at a release where neither option exists. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
August 5, 2026 07:32
This was referenced Aug 5, 2026
…reation-version-added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cncf.kubernetesoptions[kubernetes_executor] async_pod_creationandpod_creation_max_concurrencyare taggedversion_added: 10.20.0, but they ship in10.21.0. I added both in #68480 and got the version
wrong.
Two consequences:
pointing users at a release where they do not exist.
version_addedis also what keeps a newer option off an older version's config page:conf_constants.pydrops any option whoseversion_addedis greater than the packageversion being built. At
10.20.0the filter does not drop these two, so a 10.20.0 docsbuild lists options the 10.20.0 code has never heard of.
Found while verifying
cncf-kubernetes 10.21.0rc1for#70953. Three other options in the same section
carry
version_added: 10.20.0legitimately; only these two are wrong.The value was right when I wrote it and went stale in review. 10.19.0 was the latest
release when the PR was opened on 2026-06-12, so 10.20.0 was the next version. 10.20.0 was
then cut on 2026-07-23 while the PR was still open, and the PR merged six days later, which
put it in 10.21.0.
version_addedis hand-written and nothing revalidates it: the schemaaccepts any string, no pre-commit or breeze check compares it against the version being
released, and the
versions:list only gains its entry at release-prep time. Any PR thatadds a config option and stays open across a release boundary hits this.
related: #70953
Testing done
The two options do not exist anywhere in the released 10.20.0 provider, and do exist in
10.21.0rc1. Both wheels installed from PyPI / the RC SVN dist into separate virtualenvs.
Raw logs
How the value went stale
get_provider_info.pycarries the same field and is generated fromprovider.yamlbybreeze at package-prep time (
_prepare_get_provider_info_py_fileindev/breeze/src/airflow_breeze/utils/packages.py), so both are updated together.Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI following the guidelines