[v3-3-test] UI: Fix preventRunningTasks showing as raw i18n key in Clear Task dialogs (#71045) - #71240
Merged
Merged
Conversation
…ear Task dialogs (#71045) * UI: Add missing preventRunningTasks translation for Italian and Thai The Italian and Thai locale files were missing the runAndTaskActions.options.preventRunningTasks key that was added to the English locale, so users on those locales saw the raw translation key instead of localized text in the clear task dialogs. * UI: Bust the translation cache when the version lookup fails The i18n loadPath is cache-busted with the running Airflow version, but on a failed VersionService.getVersion() call it silently fell back to an un-versioned request. Behind a caching CDN or browser cache (e.g. a managed deployment like Astronomer), that can serve a translation bundle cached from before a key was added, so newer keys render as raw i18n keys (see #71007) while older, already-cached keys translate fine. Fall back to a timestamp instead so the cache is always busted. * Apply suggestion from @bbovenzi --------- (cherry picked from commit 3dd1370) Co-authored-by: krystianpl26 <113389013+krystianpl26@users.noreply.github.com> Co-authored-by: krystianpl26 <kszczepanki1@gmail.com> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Brent Bovenzi <brent@astronomer.io>
boring-cyborg
Bot
added
area:translations
area:UI
1 task
bbovenzi
marked this pull request as ready for review
August 6, 2026 14:12
bbovenzi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
potiuk,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 6, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Italian and Thai locale files were missing the
runAndTaskActions.options.preventRunningTasks key that was added to
the English locale, so users on those locales saw the raw
translation key instead of localized text in the clear task dialogs.
The i18n loadPath is cache-busted with the running Airflow version, but
on a failed VersionService.getVersion() call it silently fell back to
an un-versioned request. Behind a caching CDN or browser cache (e.g. a
managed deployment like Astronomer), that can serve a translation
bundle cached from before a key was added, so newer keys render as raw
i18n keys (see #71007) while older, already-cached keys translate
fine. Fall back to a timestamp instead so the cache is always busted.
(cherry picked from commit 3dd1370)
Co-authored-by: krystianpl26 113389013+krystianpl26@users.noreply.github.com
Co-authored-by: krystianpl26 kszczepanki1@gmail.com
Co-authored-by: Brent Bovenzi brent.bovenzi@gmail.com
Co-authored-by: Brent Bovenzi brent@astronomer.io