fix: redact non-string scalar values when key name is sensitive (#71275) - #71282
Open
waterWang wants to merge 1 commit into
Open
fix: redact non-string scalar values when key name is sensitive (#71275)#71282waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a Variable's key name matches the sensitive-keyword list,
GET /api/v2/variablescorrectly returns***for string values but returns non-string values (int, float, bool) in cleartext, leaking sensitive data.Root cause
SecretsMasker._redact_allis the fail-closed path used when a key name is judged sensitive, but it only replacesstr, recurses into containers, and returns every other type unchanged:The comment at lines 353-355 states that key-name-based redaction "must fail closed at any nesting level". It fails closed on depth, but not on type.
Fix
Change the final fall-through in
_redact_allfromreturn itemtoreturn replacement, so any non-container, non-str scalar (int, float, bool) is also redacted when the key name is sensitive.Closes #71275