Mask Connection password in Task SDK - #71306
Open
roshanprabu wants to merge 1 commit into
Open
Conversation
airflow.sdk.definitions.connection.Connection masked extra fields via mask_secret() but never masked the top-level password field, unlike the core ORM Connection. This meant secrets such as an Azure service principal secret (mapped to Connection.password) leaked into task logs unmasked whenever the connection was resolved through the Task SDK, e.g. when sourced from an AIRFLOW_CONN_* environment variable URI. Closes: apache#38144
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
airflow.sdk.definitions.connection.Connection(the Task SDK connection model used inside a running task in Airflow 3.x) masksextrafields viamask_secret(), but never masked the top-levelpasswordfield, unlike the core ORMConnection. This meant secrets such as an Azure service principal secret (which maps toConnection.password) leaked into task logs unmasked whenever the connection was resolved through the Task SDK — e.g. when sourced from anAIRFLOW_CONN_*environment variable URI.This adds the same
mask_secret(self.password)/mask_secret(quote(self.password))calls that the coreConnectionclass already performs, covering both the direct-kwargs constructor and thefrom_uripath.Closes: #38144
Test plan
test_password_is_maskedintask-sdk/tests/task_sdk/definitions/test_connection.py, covering both the kwargs constructor andfrom_uri.False) and pass with it.ruff checkandruff format --checkpass on the changed files.