Mark only a run's most recent asset event as triggering it - #71441
Merged
pierrejeambrun merged 3 commits intoAug 13, 2026
Conversation
boring-cyborg
Bot
added
area:airflow-ctl
area:API
Member
Author
Before
After
|
An asset event is linked to every dag run that consumed it, so a run that consumed several events showed "Triggered Dag Run" on each of them — in both the Asset Events view and a dag run's upstream asset events view — making it look as though more runs had been created than actually were. Only a run's most recent consumed event triggers it; the earlier ones are merely included in the run. Surfacing that distinction makes the attribution match what actually happened. closes: apache#56749
pierrejeambrun
force-pushed
the
asset-event-trigger-attribution
branch
from
August 11, 2026 15:53
fcdb661 to
e6cd04e
Compare
pierrejeambrun
marked this pull request as ready for review
August 11, 2026 16:07
pierrejeambrun
requested review from
bbovenzi,
bugraoz93,
choo121600,
dheerajturaga,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
potiuk,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 11, 2026 16:07
pierrejeambrun
marked this pull request as draft
August 11, 2026 16:09
bbovenzi
reviewed
Aug 11, 2026
pierrejeambrun
force-pushed
the
asset-event-trigger-attribution
branch
3 times, most recently
from
August 12, 2026 11:03
56cc359 to
de82546
Compare
pierrejeambrun
force-pushed
the
asset-event-trigger-attribution
branch
2 times, most recently
from
August 12, 2026 11:16
de82546 to
1273443
Compare
pierrejeambrun
marked this pull request as ready for review
August 12, 2026 13:00
Address review feedback: match each created-dagrun reference to its source event by id instead of relying on the positional order of two parallel lists. The same asset event can trigger one dag run while being merely included in another (an asset can fan out to several consumers), so the flag is resolved per (event, run) pair. The endpoints always populate it, so it is a required field with no default. Also add a query-count assertion so both asset-event endpoints are guarded against an N+1 as the number of consumed events grows.
pierrejeambrun
force-pushed
the
asset-event-trigger-attribution
branch
from
August 12, 2026 13:24
1273443 to
baf69b8
Compare
bbovenzi
approved these changes
Aug 12, 2026
Contributor
|
Just one CI failure we should resolve |
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 3f66d0f v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Contributor
Backport failed to create: airflow-ctl/v0-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 3f66d0f airflow-ctl/v0-1-testThis should apply the commit to the airflow-ctl/v0-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
1 task
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 13, 2026
) * Mark only a run's most recent asset event as triggering it An asset event is linked to every dag run that consumed it, so a run that consumed several events showed "Triggered Dag Run" on each of them — in both the Asset Events view and a dag run's upstream asset events view — making it look as though more runs had been created than actually were. Only a run's most recent consumed event triggers it; the earlier ones are merely included in the run. Surfacing that distinction makes the attribution match what actually happened. closes: apache#56749 * Match asset event triggering by id and add an N+1 query-count test Address review feedback: match each created-dagrun reference to its source event by id instead of relying on the positional order of two parallel lists. The same asset event can trigger one dag run while being merely included in another (an asset can fan out to several consumers), so the flag is resolved per (event, run) pair. The endpoints always populate it, so it is a required field with no default. Also add a query-count assertion so both asset-event endpoints are guarded against an N+1 as the number of consumed events grows. * Small adjustments (cherry picked from commit 3f66d0f) # Conflicts: # airflow-core/src/airflow/api_fastapi/common/db/assets.py # airflow-core/src/airflow/ui/src/components/Assets/TriggeredRuns.tsx
bbovenzi
pushed a commit
that referenced
this pull request
Aug 13, 2026
…71547) * Mark only a run's most recent asset event as triggering it An asset event is linked to every dag run that consumed it, so a run that consumed several events showed "Triggered Dag Run" on each of them — in both the Asset Events view and a dag run's upstream asset events view — making it look as though more runs had been created than actually were. Only a run's most recent consumed event triggers it; the earlier ones are merely included in the run. Surfacing that distinction makes the attribution match what actually happened. closes: #56749 * Match asset event triggering by id and add an N+1 query-count test Address review feedback: match each created-dagrun reference to its source event by id instead of relying on the positional order of two parallel lists. The same asset event can trigger one dag run while being merely included in another (an asset can fan out to several consumers), so the flag is resolved per (event, run) pair. The endpoints always populate it, so it is a required field with no default. Also add a query-count assertion so both asset-event endpoints are guarded against an N+1 as the number of consumed events grows. * Small adjustments (cherry picked from commit 3f66d0f) # Conflicts: # airflow-core/src/airflow/api_fastapi/common/db/assets.py # airflow-core/src/airflow/ui/src/components/Assets/TriggeredRuns.tsx
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Aug 14, 2026
) * Mark only a run's most recent asset event as triggering it An asset event is linked to every dag run that consumed it, so a run that consumed several events showed "Triggered Dag Run" on each of them — in both the Asset Events view and a dag run's upstream asset events view — making it look as though more runs had been created than actually were. Only a run's most recent consumed event triggers it; the earlier ones are merely included in the run. Surfacing that distinction makes the attribution match what actually happened. closes: apache#56749 * Match asset event triggering by id and add an N+1 query-count test Address review feedback: match each created-dagrun reference to its source event by id instead of relying on the positional order of two parallel lists. The same asset event can trigger one dag run while being merely included in another (an asset can fan out to several consumers), so the flag is resolved per (event, run) pair. The endpoints always populate it, so it is a required field with no default. Also add a query-count assertion so both asset-event endpoints are guarded against an N+1 as the number of consumed events grows. * Small adjustments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the misleading "Triggered Dag Run" attribution in the Asset Events view.
An asset event is linked to every dag run that consumed it, so when a run consumed several events the UI showed "Triggered Dag Run" on each of them — making it look as though more runs had been created than actually were. Now only a run's most recent consumed event is labelled "Triggered Dag Run"; the earlier consumed events are labelled "Included in Dag Run".
The
/assets/eventsendpoint flags the triggering event per run (ranking each run's consumed events by timestamp) and exposes it as atriggeringfield onDagRunAssetReference; the Asset Events UI renders the "triggered" and "included" groups accordingly.Scope: this covers the attribution/labelling half of the issue. The separate "older events silently ignored" scheduling behaviour was addressed by #62501 and is out of scope here.
closes: #56749
Screenshots (Asset Events view) — to attach
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines