[v3-3-test] Spell out the empty version suffix for the SVN provider build (#71247) - #71451
Merged
Conversation
1 task
vatsrahul1001
force-pushed
the
v3-3-test
branch
from
August 13, 2026 08:08
7f613ec to
a4b4c61
Compare
…uild (#71247) The command omitted --version-suffix entirely, which reads as 'the flag does not matter here' rather than 'it must be empty'. Building the SVN wave with an rc suffix produces filenames that cannot be promoted by renaming, and the mistake only surfaces at the end of the release when the promotion is attempted. (cherry picked from commit eeeaa0c) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
marked this pull request as ready for review
August 17, 2026 12:18
potiuk
force-pushed
the
backport-eeeaa0c-v3-3-test
branch
from
August 17, 2026 12:18
87d6442 to
f51caa0
Compare
potiuk
requested review from
amoghrajesh,
ashb,
bbovenzi,
bugraoz93,
choo121600,
dheerajturaga,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
shahar1,
shubhamraj-git,
vatsrahul1001 and
vincbeck
as code owners
August 17, 2026 12:18
potiuk
requested review from
eladkal,
guan404ming,
henry3260,
rawwar and
ryanahamilton
as code owners
August 17, 2026 12:19
potiuk
approved these changes
Aug 17, 2026
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Rebased onto the current v3-3-test tip; the backport replays cleanly and the tests and prek hooks it touches pass locally against this branch.
Scope-checked for a maintenance branch: this is a bugfix / documentation / dev-tooling change, with no new user-facing behaviour.
Drafted-by: Claude Code (Opus 5) (no human review before posting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command omitted --version-suffix entirely, which reads as 'the flag does
not matter here' rather than 'it must be empty'. Building the SVN wave with an
rc suffix produces filenames that cannot be promoted by renaming, and the
mistake only surfaces at the end of the release when the promotion is attempted.
(cherry picked from commit eeeaa0c)
Co-authored-by: Jarek Potiuk jarek@potiuk.com