fix: preserve extra link XCom keys across task retries - #71472
Open
waterWang wants to merge 1 commit into
Open
Conversation
waterWang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a task instance transitions to running, the execution API collects every XCom key for that task instance into
TIRunContext.xcom_keys_to_clear, and the worker deletes each one. There is no filter — the only exemption is deferral.This means a retry deletes the
_link_*rows written by every previous attempt. An extra link can only ever resolve for the attempt that ran last. This collides with #65661 (try-aware extra-links endpoint), which made the read path attempt-aware while the write path still guarantees only the latest attempt's row exists.Fix: Filter out XCom keys starting with
_link_(the defaultxcom_keyprefix forBaseOperatorLink) from thexcom_keys_to_clearlist. This preserves per-attempt extra link rows across retries, allowing the try-aware endpoint to resolve links for any attempt.Fixes #71471.