Remove unreachable break in get_bagged_dag - #72332
Open
henry3260 wants to merge 1 commit into
Open
Conversation
The walrus assignment on the preceding line returns as soon as a Dag is found, so the following `if dag:` is only ever reached when `dag` is falsy and its `break` can never run. Dropping it also makes the two bundle loops in this function read the same way.
henry3260
force-pushed
the
remove-unreachable-break-in-get-bagged-dag
branch
from
August 31, 2026 16:45
7cf5bd2 to
c7830b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The second bundle loop in
get_bagged_dagends with:The walrus assignment returns as soon as a Dag is found, so
if dag:is only ever reached whendagis falsy — thebreakcannot run. The first bundle loop in the same function already uses the plain early return, so removing it also makes the two loops read the same way.What
airflow-core/src/airflow/utils/cli.py: dropped the unreachableif dag: breakfromget_bagged_dag. No behavior change — the intent (stop searching once the Dag is found) is already served by thereturn, so no tests are added.