[v3-3-test] Respect the limit search param in the task overview duration chart (#72147) - #72357
Open
warreee wants to merge 1 commit into
Open
[v3-3-test] Respect the limit search param in the task overview duration chart (#72147)#72357warreee wants to merge 1 commit into
warreee wants to merge 1 commit into
Conversation
…pache#72147) The duration chart on the task overview always requested the last 14 task instances, ignoring the number of dag runs the user picked. The dag details layout already writes that choice to the limit search param, and the dag overview page reads a value of its own, so the task page was the only view that could not be widened. Read the same limit search param the details layout writes, falling back to the same default of 10, so the chart follows the selector and can be shared through the URL. The remaining limit on the failed task instance query is left alone: that query only reads total_entries and never renders the rows it fetches. (cherry picked from commit 4dae472)
warreee
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
September 1, 2026 04:45
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #72147 to v3-3-test. The automatic backport failed on a modify/delete conflict: Overview.test.tsx does not exist on this branch, because the task overview plugin support that introduced it was never backported.
The change to Overview.tsx cherry picks cleanly. The test file is added here in a 3.3 shaped form: only the duration chart limit tests, without the plugin cases and without the mocks for usePluginServiceGetPlugins, usePluginAppliesToContext and ReactPlugin, since none of that exists on this branch.