Add missing unit tests for the apache.hive macros plugin - #72447
Open
wtwyford wants to merge 5 commits into
Open
Add missing unit tests for the apache.hive macros plugin#72447wtwyford wants to merge 5 commits into
wtwyford wants to merge 5 commits into
Conversation
…pache#70945) The condition compared a Pydantic model class against a dict keyed by model name, so it never held. It happened to be load-bearing: it forced the field list to be rebuilt on every visit, which is what kept datamodels shared by several operations (ConnectionBody, VariableBody, BackfillPostBody) from accumulating duplicate entries. Correcting the comparison to match the key type would have silently introduced those duplicates, so the guard is dropped in favour of the unconditional reset it was already performing.
wtwyford
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
September 2, 2026 17:05
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Author
|
@rawwar could you give this a quick review? |
rawwar
self-requested a review
September 2, 2026 17:18
RNHTTR
reviewed
Sep 2, 2026
RNHTTR
requested changes
Sep 2, 2026
Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #72267
Added unit testing addressing the conditions specified by the corresponding issue, and removed the file from
OVERLOOKED_TESTSRun these tests using:
breeze testing providers-tests providers/apache/hive/tests/unit/apache/hive/plugins/test_hive.pyWas generative AI tooling used to co-author this PR?