Skip to content

Preserve OpenSearch Serverless hook configuration when deferring - #72472

Open
LE0-Lin wants to merge 2 commits into
apache:mainfrom
LE0-Lin:fix/opensearch-serverless-trigger-config
Open

Preserve OpenSearch Serverless hook configuration when deferring#72472
LE0-Lin wants to merge 2 commits into
apache:mainfrom
LE0-Lin:fix/opensearch-serverless-trigger-config

Conversation

@LE0-Lin

@LE0-Lin LE0-Lin commented Sep 3, 2026

Copy link
Copy Markdown

Closes: #72280

This preserves the AWS hook configuration when OpenSearchServerlessCollectionActiveSensor switches to its deferrable trigger.

The change:

  • forwards region_name, verify, and botocore_config from the sensor to the trigger;
  • carries those values through AwsBaseWaiterTrigger serialization;
  • uses them when constructing OpenSearchServerlessHook;
  • adds regression coverage for the sensor defer payload, hook construction, and serialization/reconstruction with both collection ID and collection name.

Local validation:

  • Ruff formatting and linting pass for all four changed files.
  • The trigger constructor/serialization consistency check passes.
  • The targeted Breeze tests could not start because Docker Desktop failed to initialize on this Windows host; the same targeted tests are covered by this PR's Linux CI.

Was generative AI tooling used to co-author this PR?
  • Yes (OpenAI Codex)

OpenAI Codex was used for limited implementation and testing assistance. All changes were reviewed and validated by me.

@LE0-Lin
LE0-Lin requested a review from o-nikolas as a code owner September 3, 2026 10:20
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Sep 3, 2026

@SameerMesiah97 SameerMesiah97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Looks good otherwise.

Comment thread providers/amazon/tests/unit/amazon/aws/sensors/test_opensearch_serverless.py Outdated
@eladkal
eladkal requested review from ferruzzi and vincbeck September 4, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward hook config to OpenSearchServerlessCollectionActiveTrigger

2 participants