Skip to content

Remove unused variables in backport_packages#9425

Merged
potiuk merged 1 commit into
apache:masterfrom
astronomer:unused-variables-backport-packages
Jun 20, 2020
Merged

Remove unused variables in backport_packages#9425
potiuk merged 1 commit into
apache:masterfrom
astronomer:unused-variables-backport-packages

Conversation

@kaxil
Copy link
Copy Markdown
Member

@kaxil kaxil commented Jun 20, 2020

There were few instances where we didn't need all the variables from the returned functions. We can remove them.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

There were few instance where we didn't need all the variables from the returned functions. We can remove them.
@kaxil kaxil requested a review from potiuk June 20, 2020 02:18
@potiuk potiuk merged commit d5262c0 into apache:master Jun 20, 2020
@kaxil kaxil deleted the unused-variables-backport-packages branch June 20, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants