Skip to content

Remove unused variables in backport_packages #9425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jun 20, 2020
Merged

Remove unused variables in backport_packages #9425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backport_packages/import_all_provider_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def import_all_provider_classes(source_path: str,

imported_classes = []
tracebacks = []
for root, dirs, files in os.walk(source_path):
for root, _, files in os.walk(source_path):
if all([not root.startswith(prefix_provider_path)
for prefix_provider_path in prefixed_provider_paths]) or root.endswith("__pycache__"):
# Skip loading module if it is not in the list of providers that we are looking for
Expand Down
4 changes: 2 additions & 2 deletions backport_packages/setup_backport_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ def check_if_classes_are_properly_named(class_summary: Dict[str, List[str]]) ->
badly_named_class_number = 0
for key, class_suffix in EXPECTED_SUFFIXES.items():
for class_full_name in class_summary[key]:
module_name, class_name = class_full_name.rsplit(".", maxsplit=1)
_, class_name = class_full_name.rsplit(".", maxsplit=1)
error_encountered = False
if not is_camel_case_with_acronyms(class_name):
print(f"The class {class_full_name} is wrongly named. The "
Expand Down Expand Up @@ -1032,7 +1032,7 @@ def update_release_notes_for_package(provider_package_id: str, current_release_v
with open(readme_file_path, "rt") as readme_file_read:
old_text = readme_file_read.read()
if old_text != readme:
file, temp_file_path = tempfile.mkstemp(".md")
_, temp_file_path = tempfile.mkstemp(".md")
try:
if os.path.isfile(readme_file_path):
copyfile(readme_file_path, temp_file_path)
Expand Down