AMBARI-26622 Fix missing mode in sudo.makedir when Ambari is running as root - #4163
Merged
Conversation
JiaLiangC
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes an inconsistent behaviour between the root and non-root branches of makedir in sudo.py.
In the root path, the
modeoption is silently dropped, while it is respected in the non-root path. Since mode is not passed, it will default to 0o777, which is unexpected behaviour when passing some other mode to the function.This is the non-root path:
In this path, mode is honoured and set as expected.
How was this patch tested?
No testing was performed - this just adds the mode parameter to os.mkdir that was previously silently ignored, but still required.