AMBARI-26641: Separate Ambari and stack JDK configuration after JDK 17 upgrade - #4188
Merged
Conversation
JiaLiangC
marked this pull request as ready for review
August 31, 2026 03:42
Contributor
Author
|
retest this please |
JiaLiangC
marked this pull request as draft
August 31, 2026 03:52
JiaLiangC
marked this pull request as ready for review
August 31, 2026 03:52
Contributor
Author
|
retest this please |
JiaLiangC
force-pushed
the
AMBARI-26641
branch
from
August 31, 2026 03:59
84a35f5 to
7b395bf
Compare
zRains
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: AMBARI-26641
What changes were proposed in this pull request?
Separate Java selection into three layers:
ambari.java.homeandambari.java.versionfor Ambari Server and Ambari-owned Agent Java helpers.stack.java.homeandstack.java.versionfor the default stack service JDK, with compatibility fallback through the legacyjava.homesetting.cluster-env/java_home_overridesfor pre-installed service or component JDKs, with component entries taking precedence and invalid entries falling back to the stack JDK.The patch also migrates existing setup and upgrade properties, validates actual Java feature versions during setup and host checks, keeps database and credential helpers on the Ambari JDK, updates JDK-compatible BIGTOP GC settings, exposes the effective Java metadata, and updates the classic and React installation workflows. Windows behavior is intentionally outside this change.
How was this patch tested?
Static checks passed for
git diff --check, the two modified XML files withxmllint --noout, modified Python files withpy_compile(excluding the existing Python 2 preinstall checker), modified classic JavaScript files withnode --check, the React TypeScript production build, and focused React lint. No Ember tests were run.Focused Agent Python tests, 6 passed:
Focused Server setup, upgrade, Java discovery, and host-check Python tests, 10 passed:
Focused Java tests under JDK 17, 93 passed:
Focused React tests, 4 files and 21 tests passed:
An Ambari-only Rocky 8 aarch64 RPM build completed successfully from the implementation commit. Its verified manifest contains only
ambari-agentandambari-server; no Hadoop ecosystem package was rebuilt. A three-node BIGTOP 3.3.0 cluster was then deployed from the digest-pinned preloaded runtime image with ZooKeeper, HDFS, YARN, Hive, and HBase. All 13 deploy phases completed successfully.Live validation confirmed:
ambari.java.home/version=17whilestack.java.home/version=8.CredentialShellhelpers actually executed with the Ambari JDK 17 path.ZOOKEEPER=JDK 8service override plusZOOKEEPER_SERVER=JDK 17component override moved one restarted ZooKeeper process to JDK 17 while NameNode and DataNode on the same host remained on JDK 8.java_home_checkaction passed on all three hosts and reported the expected JDK 17 feature version, vendor, runtime, and executable home.The first local topology included Metrics but deploy generated
VICTORIAMETRICS_SERVER, which is not present in current Ambari trunk. Metrics was removed from this JDK-focused deployment; the final supported-stack deployment passed.Please review Ambari Contributing Guide before opening a pull request.