Skip to content

[AMBARI-23415] Remove unwanted trailing slash at the end of hbase_pid… - #845

Merged
avijayanhwx merged 1 commit into
apache:trunkfrom
jaysensharma:AMBARI-23415
Apr 16, 2018
Merged

[AMBARI-23415] Remove unwanted trailing slash at the end of hbase_pid…#845
avijayanhwx merged 1 commit into
apache:trunkfrom
jaysensharma:AMBARI-23415

Conversation

@jaysensharma

@jaysensharma jaysensharma commented Mar 30, 2018

Copy link
Copy Markdown
Contributor

…_dir path in ams-hbase-env

What changes were proposed in this pull request?

While starting the AMS collector we can see that it has two slash in the PID file path

/var/run/ambari-metrics-collector//hbase-ams-regionserver.pid
/var/run/ambari-metrics-collector//hbase-ams-master.pid

It does not look good and seems error prone. It should be removed.

How was this patch tested?

Tested the fix manually.
Build was successful.

@asfgit

asfgit commented Mar 30, 2018

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1526/
Test FAILed.
Test FAILured.

@jaysensharma

Copy link
Copy Markdown
Contributor Author

@avijayanhwx
Can you please review this.

@adoroszlai

Copy link
Copy Markdown
Contributor

retest this please

@adoroszlai
adoroszlai requested a review from avijayanhwx April 16, 2018 09:12
@asfgit

asfgit commented Apr 16, 2018

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1865/
Test PASSed.

@avijayanhwx
avijayanhwx merged commit 27a6dc6 into apache:trunk Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants