Skip to content

[AMORO-1744] Rename the name of classes with the arctic identifier in the mixed-format-hive module#2835

Merged
zhoujinsong merged 3 commits into
apache:masterfrom
zhoujinsong:change-mixed-hive-arctic-names
May 15, 2024
Merged

[AMORO-1744] Rename the name of classes with the arctic identifier in the mixed-format-hive module#2835
zhoujinsong merged 3 commits into
apache:masterfrom
zhoujinsong:change-mixed-hive-arctic-names

Conversation

@zhoujinsong

Copy link
Copy Markdown
Contributor

Why are the changes needed?

As titled.

Brief change log

  • Change the name of classes with the arctic identifier
  • Change the name of variables and methods with the arctic identifier.
  • Change the comments with the arctic identifier.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions Bot added module:mixed-spark Spark module for Mixed Format module:mixed-hive Hive moduel for Mixed Format module:mixed-trino trino module for Mixed Format labels May 14, 2024
@github-actions github-actions Bot added the module:core Core module label May 14, 2024

@wangtaohz wangtaohz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong

Copy link
Copy Markdown
Contributor Author

Thanks for the review! @wangtaohz

@xleoken

xleoken commented May 14, 2024

Copy link
Copy Markdown
Member

👍

@zhoujinsong zhoujinsong merged commit eef7e5e into apache:master May 15, 2024
@zhoujinsong zhoujinsong deleted the change-mixed-hive-arctic-names branch May 15, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core Core module module:mixed-hive Hive moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:mixed-trino trino module for Mixed Format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants