fix(flight/flightsql): recover real error when prepared DoPut stream closes early#920
Merged
Merged
Conversation
…closes early When a prepared statement's bound-parameter DoPut stream is torn down by the server before the client finishes sending (e.g. the server handler returns without draining the request stream), gRPC surfaces the parameter send as a bare io.EOF. Per gRPC's contract an io.EOF from a send only means "the stream ended -- receive to learn why", but bindParameters and ExecuteUpdate forwarded that EOF directly, so the caller saw an uninformative "EOF (Unknown)" instead of the server's actual status. Treat a send-side io.EOF as a signal to fall through to the receive, which recovers the real error (or the response the server produced before closing). Adds a regression test whose server returns InvalidArgument without reading the stream; a large binding forces the send to block on flow control and observe the teardown, so the test fails deterministically without the fix. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
zeroshade
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMERS:
arrow-adbc, see fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut arrow-adbc#4497When a prepared statement's bound-parameter
DoPutstream is torn down by the server before the client finishes sending (e.g. the server handler returns without draining the request stream), gRPC surfaces the parameter send as a bareio.EOF.Per gRPC's contract an
io.EOFfrom a send only means "the stream ended -- receive to learn why", butbindParametersandExecuteUpdateforwarded that EOF directly, so the caller saw an uninformative "EOF (Unknown)" instead of the server's actual status.Treat a send-side
io.EOFas a signal to fall through to the receive, which recovers the real error (or the response the server produced before closing).Adds a regression test whose server returns
InvalidArgumentwithout reading the stream; a large binding forces the send to block on flow control and observe the teardown, so the test fails deterministically without the fix.