-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-14846: [Dev] Support GitHub Releases in download_rc_binaries.py #14848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, LGTM! There is just a small lint issue:
@@ -128,7 +128,8 @@
os.remove(dest_path)
except IOError:
pass
- raise Exception(f"Downloading {url} failed\nstdout: {stdout}\nstderr: {stderr}")
+ raise Exception(
+ f"Downloading {url} failed\nstdout: {stdout}\nstderr: {stderr}")
class Artifactory(Downloader):|
Fixed the lint. Thanks all! |
|
Benchmark runs are scheduled for baseline = 373812d and contender = 50a164e. 50a164e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Uh oh!
There was an error while loading. Please reload this page.