Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Dec 5, 2022

@lidavidm lidavidm requested a review from kou December 5, 2022 23:29
@lidavidm lidavidm marked this pull request as ready for review December 5, 2022 23:29
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lidavidm and others added 2 commits December 5, 2022 20:35
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, LGTM! There is just a small lint issue:

@@ -128,7 +128,8 @@
                 os.remove(dest_path)
             except IOError:
                 pass
-            raise Exception(f"Downloading {url} failed\nstdout: {stdout}\nstderr: {stderr}")
+            raise Exception(
+                f"Downloading {url} failed\nstdout: {stdout}\nstderr: {stderr}")
 
 
 class Artifactory(Downloader):

@lidavidm
Copy link
Member Author

lidavidm commented Dec 6, 2022

Fixed the lint. Thanks all!

@lidavidm lidavidm merged commit 50a164e into apache:master Dec 6, 2022
@lidavidm lidavidm deleted the gh-14846 branch December 6, 2022 13:33
@ursabot
Copy link

ursabot commented Dec 6, 2022

Benchmark runs are scheduled for baseline = 373812d and contender = 50a164e. 50a164e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.1% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 50a164ec ec2-t3-xlarge-us-east-2
[Finished] 50a164ec test-mac-arm
[Finished] 50a164ec ursa-i9-9960x
[Finished] 50a164ec ursa-thinkcentre-m75q
[Finished] 373812d0 ec2-t3-xlarge-us-east-2
[Finished] 373812d0 test-mac-arm
[Finished] 373812d0 ursa-i9-9960x
[Finished] 373812d0 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] Update download_rc_binaries to be able to fetch from GitHub Releases

4 participants