Skip to content

ARROW-2536: [Rust] optimize capacity allocation for ListBuilder#1985

Closed
kanekv wants to merge 1 commit intoapache:masterfrom
kanekv:fix-builder-capacity-allocation
Closed

ARROW-2536: [Rust] optimize capacity allocation for ListBuilder#1985
kanekv wants to merge 1 commit intoapache:masterfrom
kanekv:fix-builder-capacity-allocation

Conversation

@kanekv
Copy link

@kanekv kanekv commented May 2, 2018

Supposed to fix #1983 @andygrove

@andygrove
Copy link
Member

I filed a JIRA for this issue: https://issues.apache.org/jira/browse/ARROW-2536

@Kane-Sendgrid could you prefix the PR title with ARROW-2536: [Rust] please

@kanekv kanekv changed the title optimize capacity allocation for ListBuilder ARROW-2536: [Rust] optimize capacity allocation for ListBuilder May 2, 2018
@kanekv
Copy link
Author

kanekv commented May 2, 2018

@andygrove done, thanks!

@andygrove
Copy link
Member

andygrove commented May 3, 2018

@Kane-Sendgrid The build is failing because of a code formatting issue. Looks like the comment might be wrong format. We use cargo fmt to format code before committing and the build fails is formatting if off.

@kanekv kanekv force-pushed the fix-builder-capacity-allocation branch from e324006 to 39bee1e Compare May 3, 2018 04:30
@kanekv
Copy link
Author

kanekv commented May 3, 2018

@andygrove fixed

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in c884f32 May 3, 2018
@xhochy
Copy link
Member

xhochy commented May 3, 2018

@Kane-Sendgrid do you have a JIRA id so I can assign this to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust: ListBuilder::with_capacity should allocate 1 more element for offsets?

3 participants