Skip to content

ARROW-2978: [Rust] Change argument to rust fmt to fix build#2371

Closed
andygrove wants to merge 2 commits intoapache:masterfrom
andygrove:fix_rust_ci_failure
Closed

ARROW-2978: [Rust] Change argument to rust fmt to fix build#2371
andygrove wants to merge 2 commits intoapache:masterfrom
andygrove:fix_rust_ci_failure

Conversation

@andygrove
Copy link
Copy Markdown
Member

Work in progress... trying to fix the build.

@andygrove andygrove changed the title [Rust] ARROW-2978: Change argument to rust fmt to fix build [WIP] [Rust] ARROW-2978: Change argument to rust fmt to fix build Aug 5, 2018
@andygrove
Copy link
Copy Markdown
Member Author

@wesm This fixes the Rust part of the build ... at time of writing I am waiting for the JDK build to finish ... but once that is done this good to merge.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2371 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
+ Coverage   84.43%   84.49%   +0.05%     
==========================================
  Files         281      293      +12     
  Lines       44418    45329     +911     
==========================================
+ Hits        37505    38301     +796     
- Misses       6882     6997     +115     
  Partials       31       31
Impacted Files Coverage Δ
rust/src/array.rs 85.58% <100%> (ø)
rust/src/datatypes.rs 71.96% <100%> (ø)
rust/src/buffer.rs 89.13% <100%> (ø)
cpp/src/arrow/util/thread-pool-test.cc 98.91% <0%> (-0.55%) ⬇️
rust/src/lib.rs 100% <0%> (ø)
rust/src/error.rs 0% <0%> (ø)
rust/src/builder.rs 97.81% <0%> (ø)
rust/src/record_batch.rs 100% <0%> (ø)
rust/src/list.rs 100% <0%> (ø)
rust/src/bitmap.rs 100% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9101292...94c1277. Read the comment docs.

@wesm wesm changed the title [Rust] ARROW-2978: Change argument to rust fmt to fix build ARROW-2978: [Rust] Change argument to rust fmt to fix build Aug 5, 2018
Copy link
Copy Markdown
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @andygrove!

@wesm wesm closed this in 889e1e6 Aug 5, 2018
wesm pushed a commit that referenced this pull request Aug 6, 2018
Work in progress... trying to fix the build.

Author: Andy Grove <andygrove73@gmail.com>

Closes #2371 from andygrove/fix_rust_ci_failure and squashes the following commits:

94c1277 <Andy Grove> Update code formatting to keep latest version of rust fmt happy
1b3e72d <Andy Grove> Change argument to rust fmt to fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants