Skip to content

ARROW-2985: [Ruby] Add support for verifying RC - #2376

Closed
kou wants to merge 1 commit into
apache:masterfrom
kou:verify-ruby
Closed

ARROW-2985: [Ruby] Add support for verifying RC#2376
kou wants to merge 1 commit into
apache:masterfrom
kou:verify-ruby

Conversation

@kou

@kou kou commented Aug 6, 2018

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented Aug 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #2376 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
+ Coverage   84.49%   84.51%   +0.02%     
==========================================
  Files         293      293              
  Lines       45329    45329              
==========================================
+ Hits        38301    38311      +10     
+ Misses       6997     6991       -6     
+ Partials       31       27       -4
Impacted Files Coverage Δ
go/arrow/math/int64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/math_amd64.go 36.84% <0%> (+5.26%) ⬆️
go/arrow/memory/memory_amd64.go 42.85% <0%> (+14.28%) ⬆️
go/arrow/math/float64_avx2_amd64.go 100% <0%> (+100%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ba33d...f3e1fb7. Read the comment docs.

@wesm wesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

bundle exec ruby test/run-test.rb
popd

# TODO: Arrow GPU related tests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need an environment variable so users on CUDA-enabled computers can run these tests

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by #2392.

@wesm wesm closed this in ae95780 Aug 6, 2018
wesm pushed a commit that referenced this pull request Aug 6, 2018
Author: Kouhei Sutou <kou@clear-code.com>

Closes #2376 from kou/verify-ruby and squashes the following commits:

f3e1fb7 <Kouhei Sutou>  Add support for verifying RC
@kou
kou deleted the verify-ruby branch August 7, 2018 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants