Skip to content

ARROW-3530: [Java/Python] Add conversion for pyarrow.Schema from org.apache…pojo.Schema - #2774

Closed
xhochy wants to merge 1 commit into
apache:masterfrom
xhochy:ARROW-3530
Closed

ARROW-3530: [Java/Python] Add conversion for pyarrow.Schema from org.apache…pojo.Schema#2774
xhochy wants to merge 1 commit into
apache:masterfrom
xhochy:ARROW-3530

Conversation

@xhochy

@xhochy xhochy commented Oct 16, 2018

Copy link
Copy Markdown
Member

No description provided.

Comment thread python/pyarrow/jvm.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you want to get nifty:

meta = {k: metadata[k] for k in metadata.keySet()}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Comment thread python/pyarrow/tests/test_jvm.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata.items() would have been enough, iteritems is only useful if you have a very large mapping.

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants