ARROW-3621: [Go] implement Table, Record, RecordReader and TableReader#2847
Closed
sbinet wants to merge 6 commits intoapache:masterfrom
Closed
ARROW-3621: [Go] implement Table, Record, RecordReader and TableReader#2847sbinet wants to merge 6 commits intoapache:masterfrom
sbinet wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@stuartcarnie PTAL |
Codecov Report
@@ Coverage Diff @@
## master #2847 +/- ##
==========================================
- Coverage 74.8% 66.89% -7.92%
==========================================
Files 63 52 -11
Lines 4235 2670 -1565
==========================================
- Hits 3168 1786 -1382
+ Misses 993 809 -184
- Partials 74 75 +1
Continue to review full report at Codecov.
|
sbinet
force-pushed
the
issue-3621
branch
2 times, most recently
from
6d69a01 to
bab654b
Compare
wesm
changed the title
Member
|
Just rebased this |
sbinet
force-pushed
the
issue-3621
branch
2 times, most recently
from
e45cfa9 to
fcc7f94
Compare
Member
|
@stuartcarnie can you review this? |
This CL declares the Record and RecordReader interfaces. It also defines the simpleRecord and simpleRecords types that implement (resp.) the above interfaces.
Contributor
stuartcarnie
approved these changes
Oct 31, 2018
This was referenced Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL implements a few things: