ARROW-3939: [Rust] Remove macro definition for ListArrayBuilder#3100
Closed
sunchao wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-3939: [Rust] Remove macro definition for ListArrayBuilder#3100sunchao wants to merge 1 commit intoapache:masterfrom
sunchao wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@paddyhoran @andygrove @kszucs : can you review this? |
andygrove
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only implemented a few value builder types for
ListArrayBuildervia macros. This removes the macro definitions and use generic definition instead. As result, list builders with arbitrary value builder types can be defined. One more nice thing is that with Rust's type inference we don't need to explicitly specify the generic type parameters in most situations.