ARROW-4060: [Rust] Add parquet arrow converter.#3279
ARROW-4060: [Rust] Add parquet arrow converter.#3279liurenjie1024 wants to merge 2 commits intoapache:masterfrom
Conversation
|
@sunchao @andygrove Please help to review this. |
rust/src/parquet/reader/schema.rs
Outdated
There was a problem hiding this comment.
I'm curious why the no-op filter_map is needed?
There was a problem hiding this comment.
This filter_map is used to filter Nones in the vec.
|
@liurenjie1024 looks good but build is failing with compilation errors |
|
@andygrove The compilation error does not seem like caused by my commits. It seems to be caused by toolchain |
|
@liurenjie1024 Build is 👌 now |
|
@andygrove Thanks for that. There is still another failing check, could you please help to trigger it? |
|
@liurenjie1024 I'm not sure how to trigger new appveyor build ... maybe you can just push another commit to this branch? |
|
Also there are some conflicts now that need fixing |
|
@liurenjie1024 Could you fix the conflicts? |
|
Yes, I'm working on it.
…On Mon, Jan 7, 2019 at 10:43 PM Andy Grove ***@***.***> wrote:
@liurenjie1024 <https://github.com/liurenjie1024> Could you fix the
conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3279 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACpL5SpgdBJWySpEpfL9ESQpgKg-mDpDks5vA1z9gaJpZM4Zjam2>
.
--
Renjie Liu
Software Engineer, MVAD
|
0112922 to
1bfa00f
Compare
|
Thanks @liurenjie1024 |
This is the first step of adding an arrow reader and writer for parquet-rs.
This commit contains a converter which converts parquet schema to arrow schema.
Copied from this pr sunchao/parquet-rs#185.