Skip to content

ARROW-4060: [Rust] Add parquet arrow converter.#3279

Closed
liurenjie1024 wants to merge 2 commits intoapache:masterfrom
liurenjie1024:rust-arrow-schema-converter
Closed

ARROW-4060: [Rust] Add parquet arrow converter.#3279
liurenjie1024 wants to merge 2 commits intoapache:masterfrom
liurenjie1024:rust-arrow-schema-converter

Conversation

@liurenjie1024
Copy link
Copy Markdown
Contributor

This is the first step of adding an arrow reader and writer for parquet-rs.
This commit contains a converter which converts parquet schema to arrow schema.
Copied from this pr sunchao/parquet-rs#185.

@liurenjie1024
Copy link
Copy Markdown
Contributor Author

@sunchao @andygrove Please help to review this.

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why the no-op filter_map is needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filter_map is used to filter Nones in the vec.

@andygrove
Copy link
Copy Markdown
Member

@liurenjie1024 looks good but build is failing with compilation errors

@liurenjie1024
Copy link
Copy Markdown
Contributor Author

@andygrove The compilation error does not seem like caused by my commits. It seems to be caused by toolchain rustc 1.33.0-nightly (fb86d604b 2018-12-27). Could you help to trigger another build so that we can use toolchain rustc 1.33.0-nightly (9eac38634 2018-12-31)?

@andygrove
Copy link
Copy Markdown
Member

@liurenjie1024 Build is 👌 now

@liurenjie1024
Copy link
Copy Markdown
Contributor Author

@andygrove Thanks for that. There is still another failing check, could you please help to trigger it?

@andygrove
Copy link
Copy Markdown
Member

@liurenjie1024 I'm not sure how to trigger new appveyor build ... maybe you can just push another commit to this branch?

@andygrove
Copy link
Copy Markdown
Member

Also there are some conflicts now that need fixing

@andygrove
Copy link
Copy Markdown
Member

@liurenjie1024 Could you fix the conflicts?

@liurenjie1024
Copy link
Copy Markdown
Contributor Author

liurenjie1024 commented Jan 8, 2019 via email

@liurenjie1024 liurenjie1024 force-pushed the rust-arrow-schema-converter branch from 0112922 to 1bfa00f Compare January 8, 2019 11:20
@andygrove
Copy link
Copy Markdown
Member

Thanks @liurenjie1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants